Re: [Xen-devel] [PATCH 05/11] libxl: abolish useless `start' parameter to libxl__add_*

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-08-01 at 17:24 +0100, Ian Jackson wrote:
> 0 is always passed for this parameter and the code doesn't, actually,
> use it, now.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

>      {                                                                   \
>          AO_GC;                                                          \
>          int i;                                                          \
> -        int end = start + d_config->num_##type##s;                      \

This definition of end is pretty dodgy, glad to be rid of it.

> -        for (i = start; i < end; i++) {                                 \
> +        for (i = 0; i < d_config->num_##type##s; i++) {                 \
>              libxl__ao_device *aodev = libxl__multidev_prepare(aodevs);  \
> -            libxl__device_##type##_add(egc, domid, 
> &d_config->type##s[i-start], \
> +            libxl__device_##type##_add(egc, domid, &d_config->type##s[i], \
>                                         aodev);                          \
>          }                                                               \
>      }

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel