Re: [Xen-devel] [PATCH 02/11] libxl: react correctly to bootloader pty master POLLHUP

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 02/11] libxl: react correctly to 
bootloader pty master POLLHUP"):
> On Wed, 2012-08-01 at 17:24 +0100, Ian Jackson wrote:
> > Receive POLLHUP on the bootloader master pty is not an error.
> > Hopefully it means that the bootloader has exited and therefore the
> > pty slave side has no process group any more.  (At least NetBSD
> > indicates POLLHUP on the master in this case.)
...
> > +static int datacopier_pollhup_handled(libxl__egc *egc,
> > +                                      libxl__datacopier_state *dc,
> > +                                      short revents, int onwrite)
> > +{
> > +    STATE_AO_GC(dc->ao);
> > +
> > +    if (dc->callback_pollhup && (revents & POLLHUP)) {
> > +        LOG(DEBUG, "received POLLHUP on %s during copy of %s",
> > +            onwrite ? dc->writewhat : dc->readwhat,
> > +            dc->copywhat);
> > +        libxl__datacopier_kill(dc);
> > +        dc->callback(egc, dc, onwrite, -1);
> 
> You've forgotten to make this ->callback_pollhup as discussed last time.

So I have.  And this didn't show up in my testing because the callers
all either set ->callback_pollhup==0 or ==->callback.

I have fixed this in my tree.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel