Re: [Xen-devel] [PATCH] libxl: fix cleanup of tap devices in libxl__device_destroy

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-02 at 15:42 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: fix cleanup of tap 
> devices in libxl__device_destroy"):
> > 
> > >          rc = libxl__xs_transaction_start(gc, &t);
> > >          if (rc) goto out;
> > >  
> > > +        /* May not exist if this is not a tap device */
> > > +        tapdisk_params = libxl__xs_read(gc, t, tapdisk_path);
> > > +
> > >          libxl__xs_path_cleanup(gc, t, fe_path);
> > >          libxl__xs_path_cleanup(gc, t, be_path);
> > 
> > Do we deliberate ignore the error codes from these two?
> 
> I don't think so.
> 
> In general in this destroy path we should consider whether, on
> failure, we should abandon the cleanup or note the error and carry on.

Since this is a destroy operation note it and carry on I think, so as to
clean up as much as we are able.

BTW, is there a libxl__xs_transaction_abort missing in this function
too?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel