Re: [Xen-devel] [PATCH 11/13] libxl: correct some comments regarding event API and fds

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-02 at 18:27 +0100, Ian Jackson wrote:
> * libxl may indeed register more than one callback for the same fd,
>   with some restrictions.  The allowable range of responses to this by
>   the application means that this should pose no problems for users.
>   But the documentation comment should be fixed.
> 
> * Document the relaxed synchronicity semantics of the fd_modify
>   registration callback.
> 
> * A couple of comments referred to old names for functions.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl_event.h |   17 ++++++++++++++---
>  1 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxl/libxl_event.h b/tools/libxl/libxl_event.h
> index 3344bc8..cead71b 100644
> --- a/tools/libxl/libxl_event.h
> +++ b/tools/libxl/libxl_event.h
> @@ -320,13 +320,24 @@ typedef struct libxl_osevent_hooks {
>   * *for_registration_update is honoured by libxl and will be passed
>   * to future modify or deregister calls.
>   *
> - * libxl will only attempt to register one callback for any one fd.
> + * libxl may want to register more than one callback for any one fd;
> + * in that case: (i) each such registration will have at least one bit
> + * set in revents which is unique to that registration; (ii) if an
> + * event occurs which is relevant for multiple registrations the
> + * application's event system is may call libxl_osevent_occurred_fd

                                 is may ?

Probably meant just "may".

Otherwise:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(no need to resend, if you confirm the intended words are as I suggest
I'll tweak on commit)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel