Re: [Xen-devel] [PATCH] x86: fix wait code asm() constraints

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 03/08/2012 13:15, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> Yep, okay, that makes sense. Especially the use of an input operand to form
>> a memory address, although of course that cannot happen in our specific case
>> here. I have acked your patch, although I'd like an update to the patch
>> comment.
> 
> How about this as an added initial paragraph?
> 
> This fixes theoretical issues with those constraints - operands that
> get clobbered before consuming all input operands must be marked so
> according the the gcc documentation. Beyond that, the change is merely
> code improvement, not a bug fix.

Perfect!

 K.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel