Re: [Xen-devel] [PATCH 4/5] xen: events, exposes evtchn_alloc_unbound_domain

[Jean Guyader <jean.guyader@xxxxxxxxxx>]

On 10/08 08:35, Jan Beulich wrote:
> >>> On 10.08.12 at 01:25, Jean Guyader <jean.guyader@xxxxxxxxxx> wrote:
> >--- a/xen/common/event_channel.c
> >+++ b/xen/common/event_channel.c
> >@@ -159,9 +159,8 @@ static int get_free_port(struct domain *d)
> > 
> > static long evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc)
> > {
> >-    struct evtchn *chn;
> >     struct domain *d;
> >-    int            port;
> >+    evtchn_port_t  port;
> >     domid_t        dom = alloc->dom;
> >     long           rc;
> > 
> >@@ -169,26 +168,47 @@ static long 
> >evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc)
> >     if ( rc )
> >         return rc;
> > 
> >+    rc = evtchn_alloc_unbound_domain(d, &port,
> 
> Any reason you can't pass &alloc->port here directly?
> 
> >+            alloc->remote_dom == DOMID_SELF ? current->domain->domain_id
> >+                                            : alloc->remote_dom);
> 
> Any reason this can't/shouldn't be done in the called function?
> 

No specific reason for both of those thing. Here is a new version based
on your comments.

Thanks for reviewing,
Jean

Attachment: evtchn_alloc_unbound_domain.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel