Re: [Xen-devel] [[RFC PATCH 2/8]: PVH: changes related to initial boot and irq rewiring

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Thu, 16 Aug 2012 15:05:27 +0100
Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> wrote:

> On Thu, 16 Aug 2012, Mukesh Rathor wrote:
> > ---
> >  arch/x86/xen/enlighten.c |   67
> > +
> >     if (!xen_feature(XENFEAT_auto_translated_physmap)) {
> >             set_fixmap(FIX_PARAVIRT_BOOTMAP,
> >                        xen_start_info->shared_info);
> > @@ -1044,6 +1053,10 @@ void xen_setup_shared_info(void)
> >             HYPERVISOR_shared_info =
> >                     (struct shared_info
> > *)__va(xen_start_info->shared_info); 
> > +   /* PVH TBD/FIXME: vcpu info placement in phase 2 */
> > +   if (xen_pvh_domain())
> > +           return;
> 
> Is XENFEAT_auto_translated_physmap even believed to work?
> 
> If not, we could change the XENFEAT_auto_translated_physmap case and
> make it point to xen_hvm_init_shared_info, that would work for pvh as
> well.

Ok, I'll open an action item on this, and open a bug as soon as patch
is in to investigate and fix it.

> > +#ifdef CONFIG_X86_32
> > +   xen_raw_printk("ERROR: 32bit PV guest can not run in HVM
> > container\n");
> > +   return;
> > +#endif
> 
> this has to be wrong: shouldn't the return be at least below the
> following line?

Ooopsy, fixing it. Whic is why, my ex-manager at IBM used to say, "it
ain't done till it's tested!" :) :).

thanks,
Mukesh


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel