Re: [Xen-devel] [[RFC PATCH 2/8]: PVH: changes related to initial boot and irq rewiring

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Thu, 16 Aug 2012 15:09:35 -0400
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:

> On Thu, Aug 16, 2012 at 12:00:41PM -0700, Mukesh Rathor wrote:
> > On Thu, 16 Aug 2012 10:09:29 -0400
> > Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> > 
> > > > +#ifdef CONFIG_X86_32
> > > > +       xen_raw_printk("ERROR: 32bit PV guest can not run in
> > > > HVM container\n");
> > > > +       return;
> > > 
> > > Perhaps BUG() ?
> > 
> > BUG() will prob not work because it's way early in boot, which is
> > why I figured the prev if statement (right before it) has return.
> 
> It will crash with this:
> 
> XEN) domain_crash_sync called from entry.S
> .. some more data.


Do you want me to chnage the return in the prev if statement too in
that case?

        if (!xen_start_info)
                return;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel