Re: [Xen-devel] [PATCH v4] hotplug/NetBSD: check type of file to attach from params

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-08-14 at 19:09 +0100, Roger Pau Monne wrote:
> Changes since v2:
[...]
>  * Replace xenstore_write with xenstore-write in error function.
[...]
>  error() {
>       echo "$@" >&2
> -     xenstore_write $xpath/hotplug-status error
> +     xenstore-write $xpath/hotplug-status error
>       exit 1
>  }

Why this seemingly unrelated change? I don't see anything in the
comments on v2 explicitly about it.

If it is somehow necessary due to this patch then I think that deserves
mention in the changelog proper.

Is it because xenstore_write is actually specific to the Linux hotplug
scripts? (i.e. this function was just plain broken before).

While looking into this I noticed that the Linux equivalent to error()
is:
        fatal() {
          _xenstore_write "$XENBUS_PATH/hotplug-error" "$*" \
                          "$XENBUS_PATH/hotplug-status" error
          log err "$@"
          exit 1
        }

The write of the log message to hotplus-error seems like something worth
replicating (in a separate patch).

I also wonder how much of this sort of infrastructure could actually be
shared, but that's for another time.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel