Re: [Xen-devel] [RFC PATCH 4/8]: identity map, events, and xenbus related changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-16 at 02:03 +0100, Mukesh Rathor wrote:
> +                             if (xen_pvh_domain()) {
> +                                     xen_pvh_identity_map_chunk(start_pfn,
> +                                                                end_pfn);
> +                                     released += end_pfn - start_pfn;
> +                                     identity += end_pfn - start_pfn;

In the non pvh case this is done inside
xen_set_identity_and_release_chunk. I think the interface ought to be
the same in both halves of the if.

Not sure if it makes sense to push the if down into
xen_set_identity_and_release_chunk, I think the PVH case doesn't do the
release bit?

(what does happen to the old backing MFN in this case?)

> +                             } else {
> +                                     xen_set_identity_and_release_chunk(
> +                                             start_pfn, end_pfn, nr_pages,
> +                                             &released, &identity);
> +                             }
> +                     }
>                       start = end;
>               }
>       }
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 7595581..260113e 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -1814,6 +1814,13 @@ void __init xen_init_IRQ(void)
>               if (xen_initial_domain())
>                       pci_xen_initial_domain();
>  
> +             if (xen_pvh_domain()) {
> +                     xen_callback_vector();

The definition of this function is surrounded by CONFIG_XEN_PVHVM, or
did I miss where you removed that and/or the appropriate Kconfig runes
to make it so?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel