Re: [Xen-devel] [PATCH 2/5] XEN: Remove the base argument from x86_init.paging.pagetable_setup_start PVOPS

[Attilio Rao <attilio.rao@xxxxxxxxxx>]

On 21/08/12 16:41, Thomas Gleixner wrote:
> On Tue, 21 Aug 2012, Attilio Rao wrote:
>    
> > diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> > index 1019156..7999cef 100644
> > --- a/arch/x86/mm/init_32.c
> > +++ b/arch/x86/mm/init_32.c
> > @@ -445,14 +445,17 @@ static inline void permanent_kmaps_init(pgd_t *pgd_base)
> >   }
> >   #endif /* CONFIG_HIGHMEM */
> >
> > -void __init native_pagetable_setup_start(pgd_t *base)
> > +void __init native_pagetable_setup_start(void)
> >   {
> >         unsigned long pfn, va;
> > +       pgd_t *base;
> >         pgd_t *pgd;
> >      
>         pgd_t *pgd, *base = swapper_pg_dir;
>
> Please. No need to add 5 lines just for this.
>
>    
I honestly thought it was cleaner -- what is exactly your preferred 
choice? Just use swapper_pg_dir directly in the 2 places needing it?
Attilio

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel