Re: [Xen-devel] [PATCH 3/3] xen/privcmd: add PRIVCMD_MMAPBATCH_V2 ioctl

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >> +struct privcmd_mmapbatch_v2 {
> >> +  unsigned int num; /* number of pages to populate */
> > 
> > unsigend int? Not 'u32'?
> >> +  domid_t dom;      /* target domain */
> >> +  __u64 addr;       /* virtual address */
> >> +  const xen_pfn_t __user *arr; /* array of mfns */
> >> +  int __user *err;  /* array of error codes */
> > 
> > int? Not a specific type?
> 
> It's an existing interface supported by classic Xen kernels and
> currently being used by libxc.  So while I agree that it's not the best
> interface, I don't think it can be changed.

How does it work with a 64-bit dom0 and 32-bit userspace? Is the libxc
smart enough to figure out the size of the structure?
> 
> David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel