Re: [Xen-devel] [PATCH 2/3] xen/privcmd: report paged-out frames in PRIVCMD_MMAPBATCH ioctl

[Bastian Blank <waldi@xxxxxxxxxx>]

On Thu, Aug 23, 2012 at 06:13:45PM +0100, David Vrabel wrote:
> +     if (ret < 0) {
> +             if (ret == -ENOENT)
> +                     *mfnp |= 0x80000000U;
> +             else
> +                     *mfnp |= 0xf0000000U;

Please don't use magic constants.

Bastian

-- 
Respect is a rational process
                -- McCoy, "The Galileo Seven", stardate 2822.3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel