Re: [Xen-devel] [PATCH] xen: clamp bitmaps to correct number of bits

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-09-07 at 09:17 +0100, Jan Beulich wrote:
> >>> On 06.09.12 at 18:20, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Thu, 2012-09-06 at 15:47 +0100, Jan Beulich wrote:
> >>  nor did you insert whitespace into the expressions. If I
> >> were the one to commit this, I would do the adjustment while
> >> committing...
> > 
> > This whole file seems to use Linux coding style which is why I omitted
> > spaces inside the if. I made the mask "(1U << remainder) - 1" and
> > simultaneously drop the superfluous extra brackets in v2 left over from
> > removing &0xff. 
> 
> Oh yes, that's what I meant; I didn't want to you add white
> space that the Xen coding style asks for, but Linux'es doesn't.
> 
> >> Anyway, as long as there's no easily visible tools side bug
> >> addressed by this, I would think we should rather leave this
> >> for after branching - Keir?
> > 
> > I'm fine with that.
> 
> Fell free to put my ack on it when committing (but you'll need
> a separate ack from Keir anyway I believe).

Right, I wouldn't normally commit to the xen subtree even with Acks from
you both anyway, but an explicit "please commit" would cause me to do
so.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel