Re: [Xen-devel] [PATCH] xen/console: Add domain ID to output if VERBOSE

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-09-11 at 15:23 +0100, Jan Beulich wrote:
> >>> On 11.09.12 at 15:33, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> > @@ -339,6 +343,18 @@ static long guest_console_write(XEN_GUEST_HANDLE(char) 
> > buffer, int count)
> >  
> >          spin_lock_irq(&console_lock);
> >  
> > +#ifdef VERBOSE
> > +        snprintf(pbuf, sizeof(pbuf), "(%d) ", current->domain->domain_id);
> > +        if (active != current->domain->domain_id) {
> > +            sercon_puts(pbuf);
> > +            vga_puts(pbuf);
> > +
> > +            active = current->domain->domain_id;
> > +        }
> > +        if (strchr(kbuf, '\n'))
> > +            active = DOMID_IDLE;
> > +#endif
> 
> This is too simplistic - you ought to be dealing with embedded '\n',
> not just trailing ones.

hvm_print_line should perhaps become more generic?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel