Re: [Xen-devel] [PATCH 1 of 3] xl: Introduce shutdown xm compatibility option -a

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Sander Eikelenboom writes ("[Xen-devel] [PATCH 1 of 3] xl: Introduce shutdown 
xm compatibility option -a"):
>   * Add missing option -a to shutdown all guest domains

> +        for (i = 0; i<nb_domain; i++) {
> +            if (dominfo[i].domid == 0)
> +                continue;
> +
> +            shutdown_domain(dominfo[i].domid, wait, fallback_trigger);
> +        }

This isn't quite right, I think.  Surely it should initiate the
shutdown for all the domains right away, and then wait for them all to
finish ?

That's going to make the patch more complicated of course...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel