Re: [Xen-devel] [RFC PATCH 8/8]: PVH: privcmd changes

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

> I suppose it depends on whether the core "takes over" the reference
> which you hold. I think it doesn't, so this is just a leak, rather
> than putting a ballooned page back into the general allocation pool
> (things would be crashing left & right if it was doing this I reckon)
> 
> > 
> > I had looked for other hooks initially when I did this, but 
> > vm_operations_struct->close was the only one to pan out.
> > 
> > I can't really move pvh_privcmd_resv_pfns to mmu.c because the 
> > xen_remap_domain_mfn_range is called one page at a time, and I need
> > to allocate the array first. I'd have to change it to linked list,
> > worth it? Or I'd have to move and export it.
> 
> Another alternative would be to add the page array as a parameter to
> the map/unmap function, rather than relying on it propagating via
> vma_private.

I thought it was a no-no to change an exported API. Konrad, is it OK
to change an exported API like xen_remap_domain_mfn_range, I mean, are
there any guidelines?

thanks,
Mukesh



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel