Re: [Xen-devel] [PATCH mini-os enhancements for vtpm 1/8]

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Matthew Fioravante, le Mon 17 Sep 2012 17:52:38 -0400, a écrit :
> b/extras/mini-os/arch/ia64/iorw.c

> +void iowrite8(volatile void* addr, uint8_t val)
> +{
> +   printk("iorw not implemented!!\n");

Maybe even crash?  Such things can be overlooked.

> +#include <mini-os/types.h>
> +
> +void iowrite8(volatile void* addr, uint8_t val);
> +void iowrite32(volatile void* addr, uint32_t val);
> +
> +uint8_t ioread8(volatile void* addr);
> +uint32_t ioread32(volatile void* addr);

I'd say while you are at it, add 16 and 64 variants.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel