Re: [Xen-devel] [PATCH 0/4] Add V4V to Xen v5

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.09.12 at 12:27, Jean Guyader <jean.guyader@xxxxxxxxx> wrote:
> On 20 September 2012 11:22, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 20.09.12 at 11:47, Jean Guyader <jean.guyader@xxxxxxxxxx> wrote:
>>> v5 changes:
>>>         - Fix prototypes in v4v.h for do_v4v_op
>>>         - Add padding to make sure all the structures
>>>           are 64 bits aligned
>>>         - Replace [0] with []
>>
>> But that isn't standard C either (before C99 at least).
>>
> 
> I found that in xen/public/physdev.h
> 
> struct physdev_pci_device_add {
>     /* IN */
>     uint16_t seg;
>     uint8_t bus;
>     uint8_t devfn;
>     uint32_t flags;
>     struct {
>         uint8_t bus;
>         uint8_t devfn;
>     } physfn;
> #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
>     uint32_t optarr[];
> #elif defined(__GNUC__)
>     uint32_t optarr[0];
> #endif
> };
> 
> Would something similar be ok?

Yes, obviously.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel