Re: [Xen-devel] [PATCH xm/xl enhancements for vptm 1/6] xl make devid a libxl type

[Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>]

On 09/19/2012 08:19 AM, Ian Campbell wrote:
> On Tue, 2012-09-18 at 19:09 +0100, Matthew Fioravante wrote:
>> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
>> --- a/tools/ocaml/libs/xc/xenctrl.ml
>> +++ b/tools/ocaml/libs/xc/xenctrl.ml
>> @@ -16,6 +16,7 @@
>>  
>>  (** *)
>>  type domid = int
>> +type devid = int
> I don't think libxc exposes the notion of a devid, does it?
>
> In which case there's no need to have a type for it here or in the .mli.
Unfortunately it looks like the ocaml makefiles build their list of
types by using the libxl_types.idl system. Ocaml xs currently won't
compile without this.
>> diff --git a/tools/ocaml/libs/xs/xs.ml b/tools/ocaml/libs/xs/xs.ml
>> --- a/tools/ocaml/libs/xs/xs.ml
>> +++ b/tools/ocaml/libs/xs/xs.ml
>> @@ -17,6 +17,7 @@
>>  type perms = Xsraw.perms
>>  type con = Xsraw.con
>>  type domid = int
>> +type devid = int
> Likewise xenstore doesn't have a devid either AFAIK.
Same as above
>> diff --git a/tools/python/xen/lowlevel/xl/xl.c
>> b/tools/python/xen/lowlevel/xl/xl.c
>> --- a/tools/python/xen/lowlevel/xl/xl.c
>> +++ b/tools/python/xen/lowlevel/xl/xl.c
> Are you basing your patches on xen-unstable? I ask because this file
> isn't built there and so I wonder how you noticed it to change it.
I based it off of the xen-unstable tree on git, which I now realize is
the wrong tree.
> Ian.
>
The whole purpose of this patch is initialize device ids to -1 instead
of zero and the only way I could come up to do that cleanly within
libxl's type system was to create a new type. Is there another better
way to fix this problem? As long as device ids are initialized to zero,
all the xl DEVICE-attach commands will fail for attaching more than 1
device.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel