Re: [Xen-devel] [PATCH V2 3/9] libxl_json: Introduce libxl__json_object_to_yajl_gen.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-09-17 at 19:22 +0100, Anthony PERARD wrote:
> This function converts a libxl__json_object to yajl by calling every 
> yajl_gen_*
> function on a preallocated yajl_gen hand.
> 
> This helps to integrate a json_object into an already existing yajl_gen tree.
> 
> This function is used in a later patch.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_internal.h |  3 +++
>  tools/libxl/libxl_json.c     | 63 
> ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 3c2dcaa..9c1482d 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> [...]

> +    }
> +    case JSON_ERROR:

I can't see this being used anywhere, could it just be removed from the
enum?

> +    case JSON_ANY:

Is JSON_ANY sort of like a JSON "void *"? Is it ever valid to be passed
one here, IOW does this represent a coding error (==abort()) or a run
time one (== log something)?

> +    default:

If you skip this default case then some compilers will warn (a runtime
error) if we forget to add a new JSON_FOO here.

> +        return -1;
> +    }
> +}
> +
>  
>  /*
>   * JSON callbacks



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel