Re: [Xen-devel] RFC: EFER in crash notes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-09-25 at 15:18 +0100, Andrew Cooper wrote:
> While this patch is very simple, and I hope without any objection, it is
> RFC for the reason that our crash ABI is private.
> 
> The comments for XEN_ELFNOTE_CRASH_REGS does state that it is
> architecture specific, and makes no indication about the size or
> contents of the crash note.  However, any code trying to use one of
> these types of notes has to make an assumption that it if the note desc
> length is 4*8 bytes long, it is representing CR{0,2-4}.
> 
> I guess my question boils down to whether it is acceptable to change a
> private ABI which is not really so private, or whether we should make a
> formal public ABI for all of the inards of the crash notes and use that.

Is it really private? (or even "not so private"), don't external tools
like crash support it?

I suppose the size field in the notes is a sort of rudimentary version
field. Remember you can always add a new note type though.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel