[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: slightly improve stack trace on debug builds


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Tue, 25 Sep 2012 18:06:51 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 25 Sep 2012 17:07:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac2bQCe16RcN93/91EmW61QV7OHC+g==
  • Thread-topic: [Xen-devel] [PATCH] x86: slightly improve stack trace on debug builds

On 25/09/2012 17:20, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> Lol, how does your brain work this way? It took me 15 minutes to decode this
>> to something like (also I added range checks on ESP_BEFORE_EXCEPTION(regs),
>> what do you think?):
> 
> Sorry for this - just wanted to avoid having the condition evaluated
> (and spelled out) twice (and it took me a minute at most to find this
> iterate-at-most-twice solution).

It's the kind of code that is definitely easier to write than to read. ;-)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.