Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-09-26 at 13:23 +0100, Paul Durrant wrote:
> These product numbers are used by the QEMU blacklisting protocol in
> traditional QEMU and are currently coded directly into the xenstore.c
> source module. Since there are now multiple QEMUs this information
> should be pulled into a public header to avoid duplication/conflict.
> hvm-emulated-unplug.markdown has also been adjusted to reference the
> new header.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
>  docs/misc/hvm-emulated-unplug.markdown |    2 +-
>  xen/include/public/hvm/pvdrivers.h     |   50 
> ++++++++++++++++++++++++++++++++
>  2 files changed, 51 insertions(+), 1 deletions(-)
>  create mode 100644 xen/include/public/hvm/pvdrivers.h
> 
> diff --git a/docs/misc/hvm-emulated-unplug.markdown 
> b/docs/misc/hvm-emulated-unplug.markdown
> index 707fbab..ec9ce83 100644
> --- a/docs/misc/hvm-emulated-unplug.markdown
> +++ b/docs/misc/hvm-emulated-unplug.markdown
> @@ -65,4 +65,4 @@ decimal number.  `{product_name}` is a string corresponding 
> to the
>  product number in step 3.
>  
>  The master registry of product names and numbers is in
> -qemu-xen-unstable's xenstore.c.
> +xen/include/public/hvm/pvdrivers.h
> diff --git a/xen/include/public/hvm/pvdrivers.h 
> b/xen/include/public/hvm/pvdrivers.h
> new file mode 100644
> index 0000000..4be57ac
> --- /dev/null
> +++ b/xen/include/public/hvm/pvdrivers.h
> @@ -0,0 +1,50 @@
> +/*
> + * pvdrivers.h: Register of PV drivers product numbers.
> + * Copyright (c) 2012, Citrix Systems Inc.
> + * 
> + * Permission is hereby granted, free of charge, to any person obtaining a 
> copy
> + * of this software and associated documentation files (the "Software"), to
> + * deal in the Software without restriction, including without limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense, 
> and/or
> + * sell copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL 
> THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + */
> +
> +#ifndef _XEN_PUBLIC_PVDRIVERS_H_
> +#define _XEN_PUBLIC_PVDRIVERS_H_
> +
> +/*
> + * This is the master registry of product numbers for
> + * PV drivers. 
> + * If you need a new product number allocating, please
> + * post to xen-devel@xxxxxxxxxxxxxxxxxxxx  You should NOT use
> + * a product number without allocating one.
> + * If you maintain a separate versioning and distribution path
> + * for PV drivers you should have a separate product number so
> + * that your drivers can be separated from others.
> + *
> + * During development, you may use the product ID to
> + * indicate a driver which is yet to be released.

Can we add a reference to the unplug protocol doc here too please.

> + */
> +
> +#define      PVDRIVERS_XENSOURCE_WINDOWS_ID          0x0001  /* Citrix */
> +#define      PVDRIVERS_XENSOURCE_WINDOWS_NAME        "xensource-windows"
> +
> +#define      PVDRIVERS_GPLPV_WINDOWS_ID              0x0002  /* James Harper 
> */
> +#define      PVDRIVERS_GPLPV_WINDOWS_NAME            "gplpv-windows"
> +
> +#define      PVDRIVERS_EXPERIMENTAL_ID               0xffff
> +#define      PVDRIVERS_EXPERIMENTAL_NAME             "experimental"
> +
> +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel