Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header to 
serve as the register of product numbers."):
> These product numbers are used by the QEMU blacklisting protocol in
> traditional QEMU and are currently coded directly into the xenstore.c
> source module. Since there are now multiple QEMUs this information
> should be pulled into a public header to avoid duplication/conflict.
> hvm-emulated-unplug.markdown has also been adjusted to reference the
> new header.

> +#define      PVDRIVERS_XENSOURCE_WINDOWS_ID          0x0001  /* Citrix */
> +#define      PVDRIVERS_XENSOURCE_WINDOWS_NAME        "xensource-windows"
> +
> +#define      PVDRIVERS_GPLPV_WINDOWS_ID              0x0002  /* James Harper 
> */
> +#define      PVDRIVERS_GPLPV_WINDOWS_NAME            "gplpv-windows"
> +
> +#define      PVDRIVERS_EXPERIMENTAL_ID               0xffff
> +#define      PVDRIVERS_EXPERIMENTAL_NAME             "experimental"

This form for this list is very ill-suited to many obvious uses.  For
example it cannot be used to automatically generate a switch statement
or a table of values for printing.

Can I suggest

#define PVDRIVERS_ID_NAME_LIST(EACH)                      \
  EACH(WINDOWS, 0x0001 /* Citrix */, "xensource-windows") \
  ...

or something ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel