Re: [Xen-devel] [PATCH V4 00/10] Set dirty log on qemu-xen.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-10-05 at 15:30 +0100, Anthony PERARD wrote:
> This patch series enables libxl to set dirty log on QEMU upstream during
> migration through a new QMP command.

Applied.

I made one change, to Introduce libxl__json_object_to_yajl_gen, to fix:

cc1: warnings being treated as errors
libxl_json.c: In function âlibxl__json_object_to_yajl_genâ:
libxl_json.c:373: error: declaration of âindexâ shadows a global declaration
/usr/include/string.h:487: error: shadowed declaration is here

I did s/index/idx/. Hope that's ok

Ian.

> 
> The success of the call depends on the presence of the specific QMP command
> xen-set-global-dirty-log in QEMU. Patches for this command have been sent.
> 
> There is several patches that cleanup a bit the libxl_json/qmp codes.
> 
> Change since v3:
>   - Update the comment on the first patch to say that NOGC can be used.
> 
> 
> Anthony PERARD (10):
>   libxl_json: Export json_object related function.
>   libxl_json: Remove JSON_ERROR from enum.
>   libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL.
>   libxl_json: Introduce libxl__json_object_to_yajl_gen.
>   libxl_qmp: Introduces helpers to create an argument list.
>   libxl_qmp: Use qmp_parameters_* functions for param list of a QMP
>     command.
>   libxl_qmp: Simplify run of single QMP commands.
>   libxl_qmp: Introduce libxl__qmp_set_global_dirty_log.
>   libxl_dom: Call the right switch logdirty for the right DM.
>   libxl: Allow migration with qemu-xen.
> 
>  tools/libxl/libxl.c          |  17 ----
>  tools/libxl/libxl_dom.c      |  45 ++++++++++-
>  tools/libxl/libxl_internal.h |  35 ++++++--
>  tools/libxl/libxl_json.c     |  95 ++++++++++++++++++----
>  tools/libxl/libxl_qmp.c      | 189 
> ++++++++++++++++++++++++-------------------
>  5 files changed, 254 insertions(+), 127 deletions(-)
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel