Re: [Xen-devel] [PATCH] tools: xend: fix wrong condition check for xml file

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Oct 16, 2012 at 10:39:48AM +0800, Joe Jin wrote:
> Hi Konrad,
> 
> Would you please review below fix?

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> Thanks,
> Joe
> 
> 
> In commit e8d40584, it intended to check xml file size and when empty will
> return, the condition should be "if os.path.getsize(xml_path) == 0" rather
> then "if not os.path.getsize(xml_path) == 0".
> 
> Signed-off-by: Chuang Cao <chuang.cao@xxxxxxxxxx>
> Signed-off-by: Joe Jin <joe.jin@xxxxxxxxxx>
> ---
>  tools/python/xen/xend/XendStateStore.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/python/xen/xend/XendStateStore.py 
> b/tools/python/xen/xend/XendStateStore.py
> index 17a29f1..a66181d 100644
> --- a/tools/python/xen/xend/XendStateStore.py
> +++ b/tools/python/xen/xend/XendStateStore.py
> @@ -101,7 +101,7 @@ class XendStateStore:
>          if not os.path.exists(xml_path):
>              return {}
>  
> -        if not os.path.getsize(xml_path) == 0:
> +        if os.path.getsize(xml_path) == 0:
>              return {}
>  
>          dom = minidom.parse(xml_path)
> -- 
> 1.7.11.7

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel