Re: [Xen-devel] [PATCH 3/3] xen: Add V4V implementation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.10.12 at 13:52, Jean Guyader <jean.guyader@xxxxxxxxxx> wrote:
>+typedef struct v4v_ring_data_ent
>+{
>+    v4v_addr_t ring;
>+    uint16_t flags;

Missing padding here?

>+    uint32_t space_required;
>+    uint32_t max_message_size;
>+} v4v_ring_data_ent_t;

>+typedef struct v4vtables_rule
>+{
>+    v4v_addr_t src;
>+    v4v_addr_t dst;
>+    uint32_t accept;
>+    uint32_t pad;

Pointless padding here?

>+} v4vtables_rule_t;

>+DEFINE_XEN_GUEST_HANDLE (v4v_iov_t);
>+DEFINE_XEN_GUEST_HANDLE (v4v_addr_t);
>+DEFINE_XEN_GUEST_HANDLE (v4v_send_addr_t);
>+DEFINE_XEN_GUEST_HANDLE (v4v_ring_t);
>+DEFINE_XEN_GUEST_HANDLE (v4v_ring_data_ent_t);
>+DEFINE_XEN_GUEST_HANDLE (v4v_ring_data_t);
>+DEFINE_XEN_GUEST_HANDLE (v4v_info_t);
>+DEFINE_XEN_GUEST_HANDLE (v4v_pfn_t);
>+
>+DEFINE_XEN_GUEST_HANDLE (v4vtables_rule_t);
>+DEFINE_XEN_GUEST_HANDLE (v4vtables_list_t);

Extra blanks before opening parens (also elsewhere).

>+/*
>+ * Helper functions
>+ */
>+
>+static inline uint16_t
>+v4v_hash_fn (v4v_ring_id_t *id)
>+{

These and the types further down make sense to be put in a
globally visible header only if they are expected to be used
from more than one source file.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel