Re: [Xen-devel] [PATCH 08 of 16 RFC] blktap3: Introduce message types and structures

[Thanos Makatos <thanos.makatos@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell
> Sent: 26 October 2012 12:28
> To: Thanos Makatos
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 08 of 16 RFC] blktap3: Introduce
> message types and structures
> 
> On Wed, 2012-10-24 at 18:02 +0100, Thanos Makatos wrote:
> > The main difference over the the XEN version
> 
> what do you mean by "the XEN version"? Is there an existing version of
> this header somewhere?

I mean the blktap2 living in XEN, as opposed to the forked blktap2 living in 
github.

> 
> >  is the addition of the stats
> > structure (used for retrieving stats from a running tapdisk), and the
> > addition of the tapdisk_message_blkif struct, which is required for
> > the user-space counterpart of blktap/blkback to communicate with
> tapdisk.
> 
> Am I correct that the interface defined here is one which is private
> between the tapdisk processes and the supplied control tools,
> abstracted away via libblktapctl?

Yes, so this header should be private.

> 
> > +/**
> > + * Retrieves the human-readable representation of the type of the
> message.
> > + */
> > +static inline char *tapdisk_message_name(enum tapdisk_message_id id)
> > +{
> > +    switch (id) {
> 
> Would a static lookup table be nicer?

Definitely.

> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel