Re: [Xen-devel] [PATCH 09 of 16 RFC] blktap3: Introduce the tapdisk control function prototypes

[Thanos Makatos <thanos.makatos@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell
> Sent: 26 October 2012 12:33
> To: Thanos Makatos
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 09 of 16 RFC] blktap3: Introduce the
> tapdisk control function prototypes
> 
> On Wed, 2012-10-24 at 18:02 +0100, Thanos Makatos wrote:
> 
> > +    /**
> > +     * for linked lists
> > +     */
> > +    TAILQ_ENTRY(tap_list) entry;
> 
> This file doesn't seem to include the necessary header to define this?
> (Perhaps it is indirectly included?)

It's provided by blktap.h. My plan is to put commonly used header files in a 
single header file instead of repeating the inclusion in each and every source 
file.

> 
> Anyway, since I think this header is intended to be used by consumers
> of blktap (rather than internally) I think you need to namespace the
> macros. See tools/include/xen-external/bsd-sys-queue-h-seddery and its
> usages in tools/libxl/Makefile and extras/mini-os/Makefile to create
> local namespaced versions for libxl and mini-os.
> 
Just out of curiosity, what are the benefits of namespacing the macros? Google 
doesn't give anything relevant.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel