Re: [Xen-devel] [PATCH 1/2, v2] x86: use MOV instead of PUSH/POP when saving/restoring register state

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 30/10/2012 16:19, "Mats Petersson" <mats.petersson@xxxxxxxxxx> wrote:

>>   #ifdef CONFIG_FRAME_POINTER
>>   /* Indicate special exception stack frame by inverting the frame pointer.
>> */
>> -#define SETUP_EXCEPTION_FRAME_POINTER           \
>> -        movq  %rsp,%rbp;                        \
>> +#define SETUP_EXCEPTION_FRAME_POINTER(offs)     \
>> +        leaq  offs(%rsp),%rbp;                  \
>>           notq  %rbp
>>   #else
>> -#define SETUP_EXCEPTION_FRAME_POINTER
>> +#define SETUP_EXCEPTION_FRAME_POINTER(off)
> Is it too pedantic to say that "off" here should be "offs"?
> Just for consistency...

No, it's a fair point. :)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel