Re: [Xen-devel] [PATCH, v3] fix build with XEN and EARLY_PRINTK_DBGP enabled but USB_SUPPORT disabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.11.12 at 17:23, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Nov 02, 2012 at 08:38:07AM +0000, Jan Beulich wrote:
>> Since there's no possible caller of dbgp_external_startup() and
> 
> <snip>
> 
> Please just send the incremental patch, in a format that I can apply it
> (hint, as an attachment like this I can't, as I would have to hand-edit
> the attachment, and I might get it wrong...)

Here you go:

fix build of EHCI debug port code when USB_CHIPIDEA but !USB_EHCI_HCD

Relax condition of building the reset interface stubs in
drivers/usb/early/ehci-dbgp.c from USB_EHCI_HCD to just USB, to also
cover the chipidea driver re-using code from ehci-hcd.

Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

---
 drivers/usb/early/ehci-dbgp.c       |   4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- 3.7-rc3.orig/drivers/usb/early/ehci-dbgp.c
+++ 3.7-rc3/drivers/usb/early/ehci-dbgp.c
@@ -974,7 +974,7 @@ struct console early_dbgp_console = {
        .index =        -1,
 };
 
-#if IS_ENABLED(CONFIG_USB_EHCI_HCD)
+#if IS_ENABLED(CONFIG_USB)
 int dbgp_reset_prep(struct usb_hcd *hcd)
 {
        int ret = xen_dbgp_reset_prep(hcd);
@@ -1008,7 +1008,7 @@ int dbgp_external_startup(struct usb_hcd
        return xen_dbgp_external_startup(hcd) ?: _dbgp_external_startup();
 }
 EXPORT_SYMBOL_GPL(dbgp_external_startup);
-#endif /* USB_EHCI_HCD */
+#endif /* USB */
 
 #ifdef CONFIG_KGDB
 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel