Re: [Xen-devel] [PATCH 2/7] xen/arm: setup the fixmap in head.S

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c
> index 3e51252..bdf4c0e 100644
> --- a/xen/arch/arm/early_printk.c
> +++ b/xen/arch/arm/early_printk.c
> @@ -17,12 +17,11 @@
>  
>  #ifdef EARLY_UART_ADDRESS
>  
> -static void __init early_putch(char c)
> +void __init early_putch(char c)
>  {
>      volatile uint32_t *r;
>  
> -    r = (uint32_t *)((EARLY_UART_ADDRESS & 0x001fffff)
> -                     + XEN_VIRT_START + (1 << 21));
> +    r = (uint32_t *)(XEN_VIRT_START + (1 << 21));

I'm not sure I understand the significance of this address (I know this
was already here, but I figured you might know having touched it).

>  #ifdef EARLY_UART_ADDRESS
> -     /* Recover the UART address in the new address space. */
> -     lsl   r11, #11
> -     lsr   r11, #11               /* UART base's offset from 2MB base */
> -     adr   r0, start
> -     add   r0, r0, #0x200000      /* vaddr of the fixmap's 2MB slot */
> -     add   r11, r11, r0           /* r11 := vaddr (UART base address) */
> +    /* Use a virtual address to access the UART. */

Should be a tab.

(a separate patch to use soft tabs in all .S files would also be
acceptable ;-))

Actually that turned out to be my only "significant" comment so I'll
just fix it on commit.

Acked + applied.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel