Re: [Xen-devel] [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

To be honest I'd nack this kind of patch. The test is only redundant in the most trivial sense that the compiler can easily optimise away. The point of the test is to make sure that the range is OK even if the type subsequently becomes signed (to hold a -ve error, for example).

J

Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:

On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote:
No need to check whether unsigned variable is less than 0.

CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

CC: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
CC: xen-devel@xxxxxxxxxxxxxxxxxxx
CC: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx>
---
drivers/xen/events.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 4293c57..cadd7d1 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -216,7 +216,7 @@ static void xen_irq_info_pirq_init(unsigned irq,
*/
static unsigned int evtchn_from_irq(unsigned irq)
{
- if (unlikely(WARN(irq < 0 || irq >= nr_irqs, "Invalid irq %d!\n", irq)))
+ if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)))
  return 0;

 return info_for_irq(irq)->evtchn;
-- 
1.7.4.1

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel