Re: [Xen-devel] [PATCH V3] X86/vMCE: handle broken page with regard to migration

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Ian Jackson wrote:
> Liu Jinsong writes ("[PATCH V3] X86/vMCE: handle broken page with
> regard to migration"): 
>> This is V3 patch, adding handle for vMCE occur at last iteration of
>> migration: 
> 
> I think you should take off my ack, having added significant new code
> in the tools section.

OK.

> 
> About that code:
> 
>> +            /*
>> +             * if vMCE occur at last iter, do one more iter so that
>> it get +             * chance to transfer broken page's pfn_type and
>> pfn number to +             * target and then take appropriate
>> action +             */ +            if ( last_iter )
>> +            {
>> +                for ( j = 0; j < batch; j++ )
>> +                {
>> +                    if ( hvm )
>> +                        pfn_type[j] = pfn_batch[j]; +              
>> else +                        pfn_type[j] =
>> pfn_to_mfn(pfn_batch[j]); +                } +
>> +                if ( xc_get_pfn_type_batch(xch, dom, batch,
>> pfn_type) ) +                { +                   
>> PERROR("get_pfn_type_batch failed"); +                    goto out;
>> +                }
>> +
>> +                broken_page_num2 = 0;
>> +                for ( j = 0; j < batch; j++ )
>> +                    if ( pfn_type[j] == XEN_DOMCTL_PFINFO_BROKEN )
>> +                        broken_page_num2++;
>> +
>> +                if ( broken_page_num1 < broken_page_num2 )
>> +                    last_iter = 0;
>> +            }
> 
> Is this really the best way of doing this ?  Isn't there some single
> flag the hypervisor sets somewhere ?
> 
> Ian.

That will involve adding new hypercall, and notifying hypervisor whether tools 
side is at the last iter round.
This patch just re-use existed mechanism.

Thanks,
Jinsong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel