Re: [Xen-devel] [PATCH V3] X86/vMCE: handle broken page with regard to migration

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Ian Jackson wrote:
> Liu, Jinsong writes ("RE: [Xen-devel] [PATCH V3] X86/vMCE: handle
> broken page with regard to migration"): 
>> Ian Jackson wrote:
>>> Liu, Jinsong writes ("RE: [Xen-devel] [PATCH V3] X86/vMCE: handle
>>> broken page with regard to migration"):
>>>> No, at last lter, there are 4 points:
>>>> 1. start last iter
>>>> 2. get and transfer pfn_type to target
>>>> 3. copy page to target
>>>> 4. end last iter
> ...
>> It indeed checks mce after point 3 for each page, but what's the
>> advantage of keeping a separate list?
> 
> It avoids yet another loop over all the pages.  Unless I have
> misunderstood.  Which I may have, because: if it checks for mce after
> point 3 then surely that is sufficient ?  We don't need to worry about
> mces after that check.
> 
> Ian.

In fact it will only do 1~2 more iter (if vmce occur at last iter), with 
exactly 1 more page (the broken page) -- vm frozen under this case, right?
As for the case vmce occur after our check, target will be very happy (and 
lucky) run the vm w/o broken page.

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel