[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH VTPM v4 3/5] vtpm/vtpmmgr and required libs to stubdom/Makefile



As annoying as it may be, I think having a configure script or something similar is the only right answer. More hidden makefile variables and hacks makes everything more complicated. Before the existence of the configure script Xen's build system was a huge pain to work with. Its still not perfect.

So here are 2 proposals:

Add a configure.ac to stubdom. I can whip up a simple one where you can enable/disable specific stub domains. Other options could be setting the fetch urls for the libraries. People can add more options later. Now if people disable vtpm, the check for cmake goes away.

Move /tools/configure.ac to /configure.ac. Use this configure script to configure the entire build. /Makefile still exists and works with or without configuring, to enable building of the hypervisor.

If we don't want to do this now, then I vote to just make cmake a dependency for Xen without adding messy conditional hacks.

On 11/29/2012 06:41 AM, Ian Jackson wrote:
Ian Jackson writes ("Re: [PATCH VTPM v4 3/5] vtpm/vtpmmgr and required libs to 
stubdom/Makefile"):
I guess it would be possible to have an ad-hoc switch in Config.mk
(say) but I'm not sure this is better than just adding cmake as a hard
dependency.
Although, can we have a manual y/n switch in Config.mk so that if
someone has trouble with this feature they can turn off the build ?

Thanks,
Ian.


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.