Re: [Xen-devel] [PATCH] xen: get GIC addresses from DT

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 30 Nov 2012, Ian Campbell wrote:
> On Fri, 2012-11-30 at 12:25 +0000, Stefano Stabellini wrote:
> > 
> > 
> > > > +    if ( interfaces < 4 )
> > > > +    {
> > > > +        early_printk("fdt: node `%s': invalid `reg' property\n",
> > name);
> > > > +        return;
> > > > +    }
> > > > +    device_tree_get_reg(&cell, address_cells, size_cells, &start,
> > &size);
> > > > +    early_info.gic.gic_dist_addr = start;
> > > > +    device_tree_get_reg(&cell, address_cells, size_cells, &start,
> > &size);
> > > > +    early_info.gic.gic_cpu_addr = start;
> > > > +    device_tree_get_reg(&cell, address_cells, size_cells, &start,
> > &size);
> > > > +    early_info.gic.gic_hyp_addr = start;
> > > > +    device_tree_get_reg(&cell, address_cells, size_cells, &start,
> > &size);
> > > > +    early_info.gic.gic_vcpu_addr = start;
> > > 
> > > Is the GIC driver still hardcoding the register region sizes?  Or
> > does
> > > it not need the size?
> > 
> > Yes, it is. However we do know the size of all the GIC interfaces
> > because they are specified in the GIC docs.
> 
> Perhaps we ought to check that the size given meets (either == or >=)
> our expectations?

OK, in that case I am going to merge the patch with the checks with the
original

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel