Re: [Xen-devel] [PATCH 4 of 5 RFC] blktap3: Introduce xenio daemon Makefile

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-12-04 at 11:53 +0000, Thanos Makatos wrote:

> > > +override LDFLAGS = \
> > > +    -L$(XEN_ROOT)/tools/xenstore -lxenstore
> > 
> > $(LDFLAGS_libxenstore)
> 
> You mean $(LDLIBS_libxenstore), right?

Yes.

> > > +$(IBIN): $(XENIO-OBJS) xenio.o $(BLKTAP_ROOT)/control/libblktapctl.a
> > 
> > Static linking on purpose?
> > 
> > If this is a purely internal library then fine, but I have a feeling
> > that libblktapctl is intended as an interface library which others
> > (e.g.
> > libxl) will want to use?
> 
> Indeed libxl uses libblktapctl, does this mean that the xenio daemon
> must use the .so version as well?

The default assumption should be to use the shared library. Using the
static library would need to be justified.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel