Re: [Xen-devel] [PATCH] libxl: use qemu-xen (upstream QEMU) as device model by default

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 4 Dec 2012, Sander Eikelenboom wrote:
> Tuesday, December 4, 2012, 1:48:03 PM, you wrote:
> 
> > On Mon, 3 Dec 2012, Sander Eikelenboom wrote:
> >> Monday, December 3, 2012, 5:24:43 PM, you wrote:
> >> 
> >> > On 27/11/12 16:17, Stefano Stabellini wrote:
> >> >> 
> >> >> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >> >> 
> >> >> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> >> >> index 9d20086..c40f597 100644
> >> >> --- a/tools/libxl/libxl_create.c
> >> >> +++ b/tools/libxl/libxl_create.c
> >> >> @@ -144,7 +144,7 @@ int libxl__domain_build_info_setdefault(libxl__gc 
> >> >> *gc,
> >> >>      if (!b_info->device_model_version) {
> >> >>          if (b_info->type == LIBXL_DOMAIN_TYPE_HVM)
> >> >>              b_info->device_model_version =
> >> >> -                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
> >> >> +                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
> >> 
> >> > Is there anyway we may keep qemu-traditional as default for NetBSD?
> >> > Upstream Qemu is not working on NetBSD, and I'm afraid it needs some
> >> > heavy patching.
> >> 
> >> > Could a helper function be added to libxl_{netbsd/linux}.c to decide
> >> > which device model to use?
> >> 
> >> And shouldn't the example configuration files and documentation be patched 
> >> as well ?
> 
> > The example config files don't have anything on the device model.
> > However I do need to update the xl man page.
> > Thanks for the reminder!
> 
> What i did perhaps miss, are both qemu traditional and upstream going to be 
> build and installed side-by-side, so a admin can mix guest with different 
> device models during a transitional phase ?

Yes: there is a config option to select what device_model you want at VM
creation time. I am only changing the default (if no option is
specified).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel