Re: [Xen-devel] [PATCH 1 of 9 RFC] blktap3: Introduce blktap3 headers

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-12-04 at 12:26 +0000, Thanos Makatos wrote:
> > -----Original Message-----
> > From: Ian Campbell
> > Sent: 29 November 2012 15:06
> > To: Thanos Makatos
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> > Subject: Re: [Xen-devel] [PATCH 1 of 9 RFC] blktap3: Introduce blktap3
> > headers
> > 
> > On Fri, 2012-11-16 at 18:25 +0000, Thanos Makatos wrote:
> > > This patch introduces basic blktap3 header files. It also provides an
> > > plain Makefile so that the build system doesn't complain.
> > 
> > You don't want to start listing the headers etc in this Makefile as you
> > introduce them?
> 
> Ok.
> 
> > 
> > Which build system complains? We don't yet recurse into here do we?
> 
> I meant the blktap3 build system, no don't yet recurse here.
> 
> In the top-level Makefile (tools/blktap3/Makefile) I had erroneously
> put "SUBDIRS-y += include" and that required a dummy Makefile in
> tools/blktap3/includes. Removing this fixes the problem and renders
> the tools/blktap3/includes/Makefile useless.

Unless you need to install some headers so that third parties can build
against them?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel