Re: [Xen-devel] [PATCH v2 1/3] libxc: add suport for NetBSD gntdev

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 04/12/12 15:45, Ian Campbell wrote:
> On Thu, 2012-11-29 at 17:31 +0000, Roger Pau Monne wrote:
>> Add OS specific handlers for NetBSD gntdev. The main difference is
>> that NetBSD passes the VA where the grant should be set inside the
>> IOCTL_GNTDEV_MAP_GRANT_REF ioctl, instead of using mmap (this is due
>> to OS constraints).
>>
>> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> 
> Is anyone from the NetBSD camp likely to review this code?
> 
> Otherwise I'm minded to just throw it in, given that it looks OK to
> me ;-)
> 
>> +static int netbsd_gnttab_set_max_grants(xc_gnttab *xch, xc_osdep_handle h,
>> +                                       uint32_t count)
>> +{
>> +    /* NetBSD doesn't implement this feature */
>> +    return 0;
>> +}
> 
> Is -ENOSYS or "errno=ENOSYS; return -1" more appropriate then?

Thanks for the review, I've just copied Linux behaviour and returned 0
when the ioctl is not implemented, I'm afraid that if I return some kind
of error legancy applications (which expect this call to work) may abort
the whole process (this is from
xc_linux_osdep.c:linux_gnttab_set_max_grants).


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel