Re: [Xen-devel] [PATCH 1 of 6 v2] xen: sched_credit: improve picking up the idlal CPU for a VCPU

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.12.12 at 11:19, Dario Faggioli <dario.faggioli@xxxxxxxxxx> wrote:
> On Wed, 2012-12-12 at 10:04 +0000, Jan Beulich wrote: 
>> Despite you mentioning this in the description, these last two hunks
>> are, afaict, only renaming variables (and that's even debatable, as
>> the current names aren't really misleading imo), and hence I don't
>> think belong in a patch that clearly has the potential for causing
>> (performance) regressions.
>> 
> Ok, I think I can live with the current names too... Just a matter of
> taste. :-)
> 
>> That said - I don't think it will (and even more, I'm agreeable to the
>> change done).
>> 
> It has been benchmarked, together with the next change, and the results
> are in the changelog of 2/6. Numbers there show that the combination of
> those two changes are much more an improvement than anything else, at
> least for the workloads I considered (which includes sysbench and
> specjbb2005).
> 
> Anyway, I think I see your point, and I can either move the remane
> somewhere else or kill it entirely.

Yes please; I'll leave it to George to decide upon an eventual
separate renaming patch.

Btw., when you resend, can you please also fix the subject, so
grepping the changeset titles for "idle" would actually hit on this
change?

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel