Re: [Xen-devel] [PATCH 1/2] libxl: fix stale fd event callback race

[Jim Fehlig <jfehlig@xxxxxxxx>]

Ian Jackson wrote:
> Jim Fehlig writes ("Re: [Xen-devel] [PATCH 1/2] libxl: fix stale fd event 
> callback race"):
>   
>> Thanks for the patches! I've found some time to test them in the context
>> of Xen 4.2 and have some comments. For this patch, only a few nits below.
>>     
>
> Thanks for the review and testing.
>
>   
>>> -    rc = OSEVENT_HOOK(fd_register, fd, &ev->for_app_reg, events, ev);
>>> +    rc = OSEVENT_HOOK(fd,register, alloc, fd, &ev->nexus->for_app_reg,
>>>
>>>       
>> Nit, should there be a space between 'fd,' and 'register'?
>>     
>
> I did this deliberately because the macro uses token pasting to turn
> this into fd_register, at least in many of the uses.
>   

Ok.

>   
>>> Also, not that gcc complained, but register is a keyword.
>>>       
>
> The token "register" gets pasted together with other things by the
> preprocessor before the compiler sees it, so it's correct as far as
> the language spec goes.  As for it being potentially confusing,
> changing what appears here is difficult without changing the names
> in libxl_osevent_hooks.
>   

Yes, understood.

Regards,
Jim

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel