Re: [Xen-devel] [PATCH] Disable caml-stubdom by default

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 14/12/12 15:33, Fioravante, Matthew E. wrote:
> Caml was disabled in the original stubdom default build targets. I should not 
> have enabled it in my original stubdom autoconf patch.

Does caml-stubdom require something else apart from caml itself? If not
I think it should be enabled by default if caml is detected (like we do
for the caml xenstore in the tools).

> ________________________________________
> From: dunlapg@xxxxxxxxx [dunlapg@xxxxxxxxx] On Behalf Of George Dunlap 
> [dunlapg@xxxxxxxxx]
> Sent: Thursday, December 13, 2012 12:47 PM
> To: Fioravante, Matthew E.
> Cc: Ian Campbell; xen-devel@xxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH] Disable caml-stubdom by default
> 
> Is there a rationale for this?  If so, it should probably be in the commit 
> message.
> 
>  -George
> 
> 
> On Thu, Dec 13, 2012 at 3:31 PM, Matthew Fioravante 
> <matthew.fioravante@xxxxxxxxxx<mailto:matthew.fioravante@xxxxxxxxxx>> wrote:
> Signed-off-by: Matthew Fioravante 
> <matthew.fioravante@xxxxxxxxxx<mailto:matthew.fioravante@xxxxxxxxxx>>
> ---
>  stubdom/configure.ac<http://configure.ac> |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/stubdom/configure.ac<http://configure.ac> 
> b/stubdom/configure.ac<http://configure.ac>
> index db44d4a..384a94a 100644
> --- a/stubdom/configure.ac<http://configure.ac>
> +++ b/stubdom/configure.ac<http://configure.ac>
> @@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
>  # Enable/disable stub domains
>  AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
>  AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> -AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
> +AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
>  AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
>  AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
>  AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
> --
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx<mailto:Xen-devel@xxxxxxxxxxxxx>
> http://lists.xen.org/xen-devel
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel