Re: [Xen-devel] [PATCH 05/11] EPT: Make ept data structure or operations neutral

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.12.12 at 09:57, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx> wrote:

>> -----Original Message-----
>> From: Tim Deegan [mailto:tim@xxxxxxx]
>> Sent: Friday, December 14, 2012 12:04 AM
>> To: Zhang, Xiantao
>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Dong, Eddie; keir@xxxxxxx; Nakajima,
>> Jun; JBeulich@xxxxxxxx 
>> Subject: Re: [Xen-devel] [PATCH 05/11] EPT: Make ept data structure or
>> operations neutral
>> 
>> At 01:57 +0800 on 11 Dec (1355191037), xiantao.zhang@xxxxxxxxx wrote:
>> > From: Zhang Xiantao <xiantao.zhang@xxxxxxxxx>
>> >
>> > Share the current EPT logic with nested EPT case, so make the related
>> > data structure or operations netural to comment EPT and nested EPT.
>> >
>> > Signed-off-by: Zhang Xiantao <xiantao.zhang@xxxxxxxxx>
>> 
>> Since the struct ept_data is only 16 bytes long, why not just embed it in 
> the
>> struct p2m_domain, as
>> 
>> >          mm_lock_t        lock;         /* Locking of private pod structs, 
>> >  
>  *
>> >                                          * not relying on the p2m lock.    
>> >  
>  */
>> >      } pod;
>> > +    union {
>> > +        struct ept_data ept;
>> > +        /* NPT equivalent could go here if needed */
>> > +    };
>> >  };
> 
> Hi, Tim 
> Thanks for your review!    If we change it like this,   p2m.h have to 
> include asm/hvm/vmx/vmcs.h, is it acceptable ?  

I'm sure there are ways to avoid such a dependency.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel