[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1 of 6 v2] xen: sched_credit: improve picking up the idlal CPU for a VCPU
On Mon, 2012-12-17 at 08:35 +0000, Jan Beulich wrote: > >>> On 14.12.12 at 20:50, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote: > > On 12/12/12 10:04, Jan Beulich wrote: > >> This, imo, really belings into sched-if.h. > > > > Hmm, it looks like there are a number of things that could live in > > either sched-if.h or sched.h; but I think this one probably most closely > > links with thins like vcpu_is_runnable() and cpu_is_haltable(), both of > > which are in sched.h; so sched.h is where I'd put it. > > Any use of schedule_data, the type of which is declared in > sched-if.h, should be in sched-if.h - someone only including > sched.h can't make use of it anyway (and it's intended to be > used by scheduler code, i.e. shouldn't be visible to other > code). > Ok, this argument, I find quite convincing, I think I'm putting the macro in sched-if.h Thanks and Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |