[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 6 of 6 v2] xen: sched_credit: add some tracing
On Fri, 2012-12-14 at 20:05 +0000, George Dunlap wrote: > > - /* Send scheduler interrupts to designated CPUs */ > > if ( !cpumask_empty(&mask) ) > > + { > > + if ( unlikely(tb_init_done) ) > > + { > > + /* Avoid TRACE_*: saves checking !tb_init_done each step */ > > + for_each_cpu(cpu, &mask) > > + trace_var(TRC_CSCHED_TICKLE, 0, sizeof(cpu), &cpu); > > + } > > Hmm, probably should have pointed this out before, but trace_var() is a > static inline which checks tb_init_done -- you want __trace_var(). :-) > Correct. My bad. It actually was __trace_var() at the beginning (that's the reason why this particular record deserves special treatment), but I messed things up while preparing this new version. Sorry for that and thanks for having spotted this! :-) Will fix. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |