[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH special] vtpm fix cmake dependency
What os are you using? I've noticed problems with gmp on Ubuntu. -----Original Message----- From: Ian Campbell [mailto:Ian.Campbell@xxxxxxxxxx] Sent: Tuesday, December 18, 2012 9:13 AM To: Fioravante, Matthew E. Cc: xen-devel@xxxxxxxxxxxxx Subject: Re: [Xen-devel] [PATCH special] vtpm fix cmake dependency On Tue, 2012-12-18 at 11:46 +0000, Ian Campbell wrote: > On Tue, 2012-12-18 at 11:31 +0000, Ian Campbell wrote: > > On Thu, 2012-12-13 at 15:22 +0000, Matthew Fioravante wrote: > > > Ian, this one is special just for you. I'm sending it as an > > > attachment because my email client will mangle it. > > > This patch will remove the cmake dependency from xen prior to > > > autoconf stubdom > > > > Thanks, I merged this as described and also folded "Disable > > caml-stubdom by default" into the patch which added it enabled. > > > > However this still fails for me when vtpm is not enabled: > > make[1]: *** No rule to make target `mini-os-x86_64-vtpm', needed > > by `vtpm-stubdom'. Stop. > > make[1]: Leaving directory > > `/local/scratch/ianc/devel/committer.git/stubdom' > > make: *** [install-stubdom] Error 2 > > > > Something to with vtpmmgr not being conditional? > > Looks like a simple thinko. I'll merge the following into "stubdom: > Add autoconf", hopefully my testing won't find any other issues. I was just about to push this out when I though "hrm, maybe I should check this with cmake installed". I'm afraid it is broken. Spew is below. Looks like it's not finding the gmp headers -- I can see them in stubdom/gmp-x86_64/gmp.h but I can't see anything which looks like it adds the necessary -I to CFLAGS or anywhere. Branch is at: git://xenbits.xen.org/people/ianc/xen-unstable.git vtpm3 Sorry if I've broken something somewhere along the way. Please can you test fully both with and without cmake and resubmit. For reference the script I run before committing is: #!/bin/bash set -ex export PATH=/usr/lib/ccache:$PATH ( make distclean -j12 -s git clean -f -dx ./configure make dist -j12 -s find dist | sort > ../FILE_LIST ) 2>&1 | tee ../COMMITTER.LOG This makes pretty sure it is doing a fresh build with no left over cruft installed. Ian. cc -mno-red-zone -O1 -fno-omit-frame-pointer -m64 -mno-red-zone -fno-reorder-blocks -fno-asynchronous-unwind-tables -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -fno-stack-protector -fno-exceptions -isystem /local/scratch/ianc/devel/committer.git/stubdom/../extras/mini-os/include -D__MINIOS__ -DHAVE_LIBC -isystem /local/scratch/ianc/devel/committer.git/stubdom/../extras/mini-os/include/posix -isystem /local/scratch/ianc/devel/committer.git/stubdom/../tools/xenstore -isystem /local/scratch/ianc/devel/committer.git/stubdom/../extras/mini-os/include/x86 -isystem /local/scratch/ianc/devel/committer.git/stubdom/../extras/mini-os/include/x86/x86_64 -U __linux__ -U __FreeBSD__ -U __sun__ -nostdinc -isystem /local/scratch/ianc/devel/committer.git/stubdom/../extras/mini-os/include/posix -isystem /local/scratch/ianc/devel/committer.git/stubdom/cross-root-x86_64/x86_64-xen-elf/include -isystem /usr/lib/gcc/x86_64-linux-gnu/4.4.5/include -isystem /local/scratch/ianc/devel/committer.git/stubdom/lwip-x86_64/src/include -isystem /local/scratch/ianc/devel/committer.git/stubdom/lwip-x86_64/src/include/ipv4 -I/local/scratch/ianc/devel/committer.git/stubdom/include -I/local/scratch/ianc/devel/committer.git/stubdom/../xen/include -I../tpm_emulator-x86_64/build -I../tpm_emulator-x86_64/tpm -I../tpm_emulator-x86_64/crypto -I../tpm_emulator-x86_64 -c -o vtpm.o vtpm.c In file included from ../tpm_emulator-x86_64/crypto/rsa.h:22, from ../tpm_emulator-x86_64/tpm/tpm_structures.h:22, from ../tpm_emulator-x86_64/tpm/tpm_marshalling.h:21, from vtpm.c:31: ../tpm_emulator-x86_64/crypto/bn.h:27:17: error: gmp.h: No such file or directory In file included from ../tpm_emulator-x86_64/crypto/rsa.h:22, from ../tpm_emulator-x86_64/tpm/tpm_structures.h:22, from ../tpm_emulator-x86_64/tpm/tpm_marshalling.h:21, from vtpm.c:31: ../tpm_emulator-x86_64/crypto/bn.h:28: error: expected â=â, â,â, â;â, âasmâ or â__attribute__â before âtpm_bn_tâ ../tpm_emulator-x86_64/crypto/bn.h:31: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:33: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:35: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:37: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:39: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:41: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:43: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:45: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:47: error: expected â)â before âoutâ ../tpm_emulator-x86_64/crypto/bn.h:49: error: expected declaration specifiers or â...â before âtpm_bn_tâ ../tpm_emulator-x86_64/crypto/bn.h:51: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:53: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:55: error: expected â)â before âaâ ../tpm_emulator-x86_64/crypto/bn.h:57: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:59: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:61: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:63: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:65: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:67: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:69: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:71: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:73: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:75: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:77: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:79: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:81: error: expected â)â before âresâ ../tpm_emulator-x86_64/crypto/bn.h:83: error: expected â)â before âresâ In file included from ../tpm_emulator-x86_64/tpm/tpm_structures.h:22, from ../tpm_emulator-x86_64/tpm/tpm_marshalling.h:21, from vtpm.c:31: ../tpm_emulator-x86_64/crypto/rsa.h:25: error: expected specifier-qualifier-list before âtpm_bn_tâ ../tpm_emulator-x86_64/crypto/rsa.h:35: error: expected specifier-qualifier-list before âtpm_bn_tâ In file included from ../tpm_emulator-x86_64/tpm/tpm_marshalling.h:21, from vtpm.c:31: ../tpm_emulator-x86_64/tpm/tpm_structures.h: In function âfree_TPM_PERMANENT_DATAâ: ../tpm_emulator-x86_64/tpm/tpm_structures.h:2244: error: âtpm_rsa_private_key_tâ has no member named âsizeâ make[2]: *** [vtpm.o] Error 1 make[2]: Leaving directory `/local/scratch/ianc/devel/committer.git/stubdom/vtpm' make[1]: *** [vtpm] Error 2 make[1]: Leaving directory `/local/scratch/ianc/devel/committer.git/stubdom' make: *** [install-stubdom] Error 2 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |