Re: [Xen-devel] [PATCH 5/5] xen: arm: fix guest register access.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-12-18 at 18:40 +0000, Stefano Stabellini wrote:
> > +    case 8 ... 12: /* Register banked in FIQ mode */
> > +        BUILD_BUG_ON(REGOFFS(r8_fiq) + 4*sizeof(uint32_t) != 
> > REGOFFS(r12_fiq));
> > +        if ( fiq_mode(regs) )
> > +            return &regs->r8_fiq + reg - 8;
> > +        else
> > +            return &regs->r8_fiq + reg - 8;
> 
> what's the point of this if?

Oops, the else case shouldn't have the _fiq suffix!

(seriously, please can you start trimming your quotes! I nearly missed
this single line comment among the 100 lines you needlessly quoted)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel